This repository was archived by the owner on Jun 11, 2025. It is now read-only.
Merged
Conversation
lgavillet
suggested changes
Jan 26, 2017
| $chip-height: 32px !default; | ||
| $chip-line-height: 32px !default; | ||
| $chip-font-size: 13px !default; | ||
| $chip-font-weight: 500 !default; |
Contributor
There was a problem hiding this comment.
This is the default library, no changes should be done here. Please move it there, if needed: app/assets/stylesheets/mtl/extend/_chips.scss
ruinunes
force-pushed
the
rn-add-flexibility-to-chip
branch
from
95e38d4 to
3930f24
Compare
lgavillet
suggested changes
Jan 30, 2017
| $chip-height: 22px !default; | ||
| $chip-line-height: 23px !default; | ||
| $chip-font-size: .7rem !default; | ||
| $chip-font-weight: normal !default; |
Contributor
There was a problem hiding this comment.
- This is not the default values of Materialize https://github.com/Dogfalo/materialize/blob/master/sass/components/_chips.scss
- While checking the values, found that those values might be reported here: https://github.com/Dogfalo/materialize/blob/master/sass/components/_chips.scss#L14-L28 So, can you please update accordingly please?
ruinunes
force-pushed
the
rn-add-flexibility-to-chip
branch
from
416e263 to
a132d8c
Compare
Contributor
Author
|
@lgavillet updated. |
Contributor
|
Missing point 2 (about the images and close) |
ruinunes
force-pushed
the
rn-add-flexibility-to-chip
branch
from
a014ac3 to
a619f49
Compare
Contributor
Author
|
Thx. I've added changes affecting child elements. |
lgavillet
suggested changes
Jan 31, 2017
| .close { | ||
| line-height: $chip-line-height; | ||
| font-size: $chip-font-size + 3px; | ||
| padding-left: $chip-height / 5; |
| > img { | ||
| border-radius: $chip-border-radius; | ||
| height: $chip-height; | ||
| margin-right: $chip-height / 5; |
| font-weight: $chip-font-weight; | ||
| white-space: nowrap; | ||
| padding-right: $chip-height / 2; | ||
| > img { |
| margin-right: $chip-height / 5; | ||
| width: $chip-height; | ||
| } | ||
| .close { |
Contributor
|
Also possible to add something in CHANGES.md & REFERENCE.md files? To explain the additional configuration vars of the chips? |
lgavillet
reviewed
Jan 31, 2017
| .close { | ||
| font-size: $chip-font-size + 3px; | ||
| height: $chip-height; | ||
| line-height: $chip-line-height; |
Contributor
There was a problem hiding this comment.
here, shouldn't we add a padding-left as 1/4 of the font-size to keep the proper alignment, like we did in the img margin right? Asking.
Contributor
Author
There was a problem hiding this comment.
went with padding-left: ($chip-font-size + 3px) / 2;
ruinunes
force-pushed
the
rn-add-flexibility-to-chip
branch
2 times, most recently
from
3ca6022 to
27142b9
Compare
lgavillet
force-pushed
the
rn-add-flexibility-to-chip
branch
from
de41ce3 to
596b2ba
Compare
lgavillet
approved these changes
Feb 1, 2017
ruinunes
commented
Feb 2, 2017
| $chip-font-size: 13px !default; | ||
| $chip-font-weight: 500 !default; | ||
| $chip-border-radius: 500px !default; | ||
| $chip-border-radius: 16px !default; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concerning component http://materializecss.com/chips.html
This adds scss variables for
height,font-size,font-weightandline-height.