Add gh extension support and fix README default width#5
Merged
Conversation
- Add root wrapper script for gh extension install compatibility - Update README default width values from 500 to 800
When invoked via `bash -c` or interactive shells with history expansion enabled, `!` inside `<!--` gets escaped to `\!`, causing `<\!--` in the body text. This made placeholder detection fail, resulting in unresolved placeholders in the final comment alongside duplicated image tags. Normalize `<\!--` back to `<!--` before placeholder processing.
Owner
Author
|
Upload test (fixed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh extension install atani/gh-attachでインストール可能にするため、ルートにラッパースクリプトを追加--body内の HTML コメントプレースホルダーが置換されないバグを修正Changes
gh-attach(root):bin/gh-attachを呼び出すラッパースクリプト（gh extension対応）README.md: Options テーブルと Notes 内のデフォルト幅を 800 に更新bin/gh-attach: bash history expansion で<!--が<\!--にエスケープされた場合の正規化処理を追加Test plan
gh extension install .でローカルインストールできるgh attach --version/--helpが動作する--releaseモードで画像アップロード＋プレースホルダー置換が正常動作する