Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes GraphiteEditor#4026
When the Artboard tool is selected, pressing G (grab) or S (scale) now triggers the same keyboard-driven transformation that the Select and Path tools already support. This reuses the existing GRS infrastructure in
TransformLayerMessageHandler— no new transformation logic was added.Changes
ToolType::Artboardin theOriginalTransforms::Layergate so the GRS system snapshots artboard layer transforms. Also bypass the artboard filter inSelected::bounding_box()when the Artboard tool is active.active_tool_typethroughrecalculate_pivot()andrecalculate_transform()so the pivot includes artboards when the Artboard tool is active.active_tool_typethroughcreate_bounding_box_transform()so GRS computes correct local axes for artboards. Existing Select tool call sites passToolType::Selectto preserve current behavior.Rotate(R) for artboards since their bounds are axis-aligned integer rectangles.Test plan