Simplify e2e: deterministic waits and locale-agnostic selectors#32
Draft
Copilot wants to merge 1 commit intofeature/simplify-e2e-testsfrom
Draft
Simplify e2e: deterministic waits and locale-agnostic selectors#32Copilot wants to merge 1 commit intofeature/simplify-e2e-testsfrom
Copilot wants to merge 1 commit intofeature/simplify-e2e-testsfrom
Conversation
Open
Copilot
AI
changed the title
[WIP] Simplify e2e
Simplify e2e: deterministic waits and locale-agnostic selectors
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E helpers relied on
waitForTimeoutfixed delays and locale-sensitive text selectors (has-text("Save"),has-text("Cancel")), causing flaky tests in non-English locales and under variable load.Changes
Deterministic loading guards (
navigateToFolder,navigateToRoot,clearSearch): wait for.media-library-loadingto disappear before returning instead of assuming the grid is ready.Locale-agnostic TinyMCE button selectors: replace text-based matching with CSS class structure:
.tox-button:not(.tox-button--secondary):not(.tox-button--naked).tox-button--secondarywith text-based fallbacks retained as safety netEscape/Enterkeyboard fallback and wait for dialoghiddenstate.Tighter nav click target in
idevices-import-regression.spec.ts: use.node-text-spaninstead of.nav-element-text(the container also holds dropdown buttons).Replaced
waitForTimeout(200)in the regression spec with a two-phasedata-readyattribute poll on#node-content:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.