Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| const activeStep = frame.dataset.resolateActiveStep; | ||
| if (!activeStep) { | ||
| return; | ||
| } | ||
| setStepState(activeStep, 'done', strings.stepDone || ''); |
There was a problem hiding this comment.
Do not mark iframe exports as done without verifying success
The modal’s load handler on the hidden export <iframe> sets each step to done whenever the frame finishes loading, regardless of whether the request actually produced a file. In CDN mode the export endpoints return a redirect with an error notice when ZetaJS conversions are unavailable, but because the request now runs inside the hidden frame the notice is invisible and the step shows as completed even though no download occurred. Users will see a successful state with no output and no explanation. Consider inspecting the iframe response (e.g. by checking headers or propagating the redirected URL to the main window) and displaying an error status instead of assuming every load event is a success.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ecd0c229c88322be53bb4131ad0f38