Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 661e21450e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 'type' => 'single', | ||
| 'value' => '2025', | ||
| ), | ||
| 'tipo_persona' => array( |
There was a problem hiding this comment.
Map memoria demo data to the persona placeholder
When seeding the memoria-pago demo (maybe_seed_demo_documents → get_memoria_pago_demo()), this entry uses the slug tipo_persona, but the bundled template defines the field as persona (from fixtures/memoria_pago.odt). Because save_demo_fields() writes values by slug, the seeded document never populates the actual persona placeholder, so generated demo output is missing that field value.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This pull request adds support for two new document types—"Memoria justificativa de pago" and "Respuesta a escrito"—to the demo data seeding process in
class-documentate-demo-data.php. It ensures that fixture files, type definitions, and example demo documents for these types are properly imported and seeded, enhancing the coverage and usability of demo data for testing and onboarding.New document types and fixture integration:
memoria_pago.odtandrespuesta_escrito.odtfixture files in the default media import process to ensure these templates are available.Demo document seeding:
Demo data examples:
get_memoria_pago_demo()andget_respuesta_escrito_demo()to supply structured example data for the new document types, including realistic field values and arrays for invoice items and response text.