Align doc types admin with WordPress coding standard#16
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+28
to
+98
| * @param string $hook Current hook suffix. | ||
| */ | ||
| public function enqueue_assets( $hook ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable | ||
| $screen = function_exists( 'get_current_screen' ) ? get_current_screen() : null; | ||
| if ( ! $screen || 'edit-resolate_doc_type' !== $screen->id ) { | ||
| return; | ||
| } | ||
|
|
||
| wp_enqueue_media(); | ||
| wp_enqueue_script( 'jquery' ); | ||
| wp_enqueue_style( 'wp-color-picker' ); | ||
| wp_enqueue_script( | ||
| 'resolate-doc-types', | ||
| plugins_url( 'admin/js/resolate-doc-types.js', RESOLATE_PLUGIN_FILE ), | ||
| array( 'jquery', 'underscore', 'wp-color-picker' ), | ||
| RESOLATE_VERSION, | ||
| true | ||
| ); | ||
| wp_enqueue_style( | ||
| 'resolate-doc-types', | ||
| plugins_url( 'admin/css/resolate-doc-types.css', RESOLATE_PLUGIN_FILE ), | ||
| array(), | ||
| RESOLATE_VERSION | ||
| ); | ||
| wp_enqueue_media(); | ||
| wp_enqueue_script( 'jquery' ); | ||
| wp_enqueue_style( 'wp-color-picker' ); | ||
| wp_enqueue_script( | ||
| 'resolate-doc-types', | ||
| plugins_url( 'admin/js/resolate-doc-types.js', RESOLATE_PLUGIN_FILE ), | ||
| array( 'jquery', 'underscore', 'wp-color-picker' ), | ||
| RESOLATE_VERSION, | ||
| true | ||
| ); | ||
| wp_enqueue_style( | ||
| 'resolate-doc-types', | ||
| plugins_url( 'admin/css/resolate-doc-types.css', RESOLATE_PLUGIN_FILE ), | ||
| array(), | ||
| RESOLATE_VERSION | ||
| ); | ||
|
|
||
| $term_id = isset( $_GET['tag_ID'] ) ? intval( $_GET['tag_ID'] ) : 0; // phpcs:ignore WordPress.Security.NonceVerification.Recommended | ||
| $schema = array(); | ||
| $template_id = 0; | ||
| $template_ext = ''; | ||
| if ( $term_id > 0 ) { | ||
| $schema = get_term_meta( $term_id, 'schema', true ); | ||
| if ( ! is_array( $schema ) ) { | ||
| $schema = get_term_meta( $term_id, 'resolate_type_fields', true ); | ||
| if ( ! is_array( $schema ) ) { | ||
| $schema = array(); | ||
| } | ||
| } | ||
| $template_id = intval( get_term_meta( $term_id, 'resolate_type_template_id', true ) ); | ||
| $template_ext = sanitize_key( (string) get_term_meta( $term_id, 'resolate_type_template_type', true ) ); | ||
| } | ||
| $term_id = isset( $_GET['tag_ID'] ) ? intval( $_GET['tag_ID'] ) : 0; // phpcs:ignore WordPress.Security.NonceVerification.Recommended | ||
| $schema = array(); | ||
| $template_id = 0; | ||
| $template_ext = ''; | ||
| if ( $term_id > 0 ) { | ||
| $schema = get_term_meta( $term_id, 'schema', true ); | ||
| if ( ! is_array( $schema ) ) { | ||
| $schema = get_term_meta( $term_id, 'resolate_type_fields', true ); | ||
| if ( ! is_array( $schema ) ) { | ||
| $schema = array(); | ||
| } | ||
| } | ||
| $template_id = intval( get_term_meta( $term_id, 'resolate_type_template_id', true ) ); | ||
| $template_ext = sanitize_key( (string) get_term_meta( $term_id, 'resolate_type_template_type', true ) ); | ||
| } | ||
|
|
||
| $schema_slugs = array(); | ||
| foreach ( $schema as $item ) { | ||
| if ( is_array( $item ) && ! empty( $item['slug'] ) ) { | ||
| $schema_slugs[] = sanitize_key( $item['slug'] ); | ||
| } | ||
| } | ||
| $schema_slugs = array(); | ||
| foreach ( $schema as $item ) { | ||
| if ( is_array( $item ) && ! empty( $item['slug'] ) ) { | ||
| $schema_slugs[] = sanitize_key( $item['slug'] ); | ||
| } | ||
| } | ||
|
|
||
| wp_localize_script( | ||
| 'resolate-doc-types', | ||
| 'resolateDocTypes', | ||
| array( | ||
| 'ajax' => array( | ||
| 'url' => admin_url( 'admin-ajax.php' ), | ||
| 'nonce' => wp_create_nonce( 'resolate_doc_type_template' ), | ||
| ), | ||
| 'i18n' => array( | ||
| 'select' => __( 'Seleccionar archivo', 'resolate' ), | ||
| 'remove' => __( 'Eliminar', 'resolate' ), | ||
| 'fieldsDetected' => __( 'Campos detectados', 'resolate' ), | ||
| 'noFields' => __( 'No se encontraron campos en la plantilla.', 'resolate' ), | ||
| 'typeDocx' => __( 'Plantilla DOCX', 'resolate' ), | ||
| 'typeOdt' => __( 'Plantilla ODT', 'resolate' ), | ||
| 'typeUnknown' => __( 'Formato desconocido', 'resolate' ), | ||
| 'diffAdded' => __( 'Campos nuevos', 'resolate' ), | ||
| 'diffRemoved' => __( 'Campos eliminados', 'resolate' ), | ||
| ), | ||
| 'schema' => $schema_slugs, | ||
| 'templateId' => $template_id, | ||
| 'templateExt'=> $template_ext, | ||
| ) | ||
| ); | ||
| } | ||
| wp_localize_script( | ||
| 'resolate-doc-types', | ||
| 'resolateDocTypes', | ||
| array( | ||
| 'ajax' => array( | ||
| 'url' => admin_url( 'admin-ajax.php' ), | ||
| 'nonce' => wp_create_nonce( 'resolate_doc_type_template' ), | ||
| ), | ||
| 'i18n' => array( | ||
| 'select' => __( 'Seleccionar archivo', 'resolate' ), | ||
| 'remove' => __( 'Eliminar', 'resolate' ), | ||
| 'fieldsDetected' => __( 'Campos detectados', 'resolate' ), | ||
| 'noFields' => __( 'No se encontraron campos en la plantilla.', 'resolate' ), | ||
| 'typeDocx' => __( 'Plantilla DOCX', 'resolate' ), | ||
| 'typeOdt' => __( 'Plantilla ODT', 'resolate' ), | ||
| 'typeUnknown' => __( 'Formato desconocido', 'resolate' ), | ||
| 'diffAdded' => __( 'Campos nuevos', 'resolate' ), | ||
| 'diffRemoved' => __( 'Campos eliminados', 'resolate' ), | ||
| ), | ||
| 'schema' => $schema_slugs, | ||
| 'templateId' => $template_id, | ||
| 'templateExt' => $template_ext, | ||
| ) |
Check warning
Code scanning / PHPMD
Code Size Rules: CyclomaticComplexity Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
admin/class-resolate-doc-types.phpto follow the WordPress Coding Standards with tabs, docblocks, and consistent array indentationAGENTS.mdso developers can auto-fix with phpcbf before linting with phpcsTesting
./vendor/bin/phpcbf --standard=.phpcs.xml.dist(fails: No such file or directory)./vendor/bin/phpcs --standard=.phpcs.xml.dist(fails: No such file or directory)https://chatgpt.com/codex/tasks/task_e_68ed7929f00883228c8ac360c3c1d942