Load ZetaJS assets from CDN for document editing#5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| if ( ! defined( 'RESOLATE_ZETAJS_CDN_BASE' ) ) { | ||
| define( 'RESOLATE_ZETAJS_CDN_BASE', 'https://cdn.zetaoffice.net/zetaoffice_latest/' ); | ||
| } |
There was a problem hiding this comment.
Default CDN constant disables configured ZetaJS CLI PDFs
Defining RESOLATE_ZETAJS_CDN_BASE to a non‑empty URL by default makes Resolate_Zetajs_Converter::is_cdn_mode() return true on every install, so generate_pdf() now always returns the browser‑only error and the PDF button is disabled even when RESOLATE_ZETAJS_BIN was already configured. Existing sites that previously produced PDFs via the local CLI will regress unless administrators manually override this constant to an empty string. Consider leaving the CDN base undefined by default or only setting it when the CDN mode is explicitly enabled so server-side conversions keep working out of the box.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ecb8a07e8c8322a6bf2659a6177b5f