Skip to content

Add ci pipeline#54

Merged
erseco merged 3 commits intomainfrom
feature/add-e2e-to-pipeline
Nov 28, 2025
Merged

Add ci pipeline#54
erseco merged 3 commits intomainfrom
feature/add-e2e-to-pipeline

Conversation

@erseco
Copy link
Copy Markdown
Collaborator

@erseco erseco commented Nov 28, 2025

This pull request enhances the CI workflow by adding support for end-to-end (E2E) testing using Playwright. The main changes include installing Playwright, running E2E tests, and uploading test artifacts if failures occur.

E2E Testing Integration:

  • Added steps to install npm dependencies and Playwright in the CI workflow (.github/workflows/ci.yml).
  • Added a step to run E2E tests using make test-e2e with the CI environment variable set.

Artifact Handling:

  • Configured the workflow to upload Playwright test artifacts to GitHub Actions when E2E tests fail, retaining them for 7 days.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml Outdated
Comment on lines +146 to +147
- name: Install npm dependencies and Playwright
run: npm ci && npx playwright install --with-deps chromium
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid npm ci without package-lock

The new Playwright setup runs npm ci, but the repository does not include a package-lock.json or npm-shrinkwrap.json and npm ci refuses to run without one (per npm help ci), so this step will exit with EUSAGE before installing dependencies. That makes the CI job fail before Playwright is installed or any E2E tests run; use npm install or add a lockfile to keep the workflow passing.

Useful? React with 👍 / 👎.

@erseco erseco merged commit f459116 into main Nov 28, 2025
4 checks passed
@erseco erseco deleted the feature/add-e2e-to-pipeline branch November 30, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant