Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive set of new unit tests for critical components of the Documentate plugin, focusing on export handlers, the admin converter template, and the uninstall process. Additionally, it updates the SonarQube scanner version in CI. These changes significantly improve test coverage, ensuring that key functionality, security checks, and integration points are properly validated.
Testing improvements
ExportHandlerTestto verify the behavior ofExport_Handlerand its subclasses (Export_DOCX_Handler,Export_ODT_Handler,Export_PDF_Handler), including format/mime type methods, input sanitization, permission checks, and class structure.DocumentateConverterTemplateTestto ensure theadmin/documentate-converter-template.phpfile contains all required HTML, PHP variables, JavaScript integrations (including ZetaJS), AJAX handling, error handling, and CSS styles.UninstallTestto check the existence and security of theuninstall.phpfile, verifying the presence of guard clauses and correct behavior when the uninstall constant is defined.CI/CD update
.gitlab-ci.ymlto ensure the latest static analysis tooling is used.