Fix compilation error when specific adapter is not included#64
Merged
mgiacomini merged 2 commits intoateliware:masterfrom Mar 7, 2019
Merged
Fix compilation error when specific adapter is not included#64mgiacomini merged 2 commits intoateliware:masterfrom
mgiacomini merged 2 commits intoateliware:masterfrom
Conversation
kelvinst
approved these changes
Mar 7, 2019
| environment: | ||
| - POSTGRES_PASSWORD=postgres | ||
| ports: | ||
| - 5432:5432 |
Contributor
There was a problem hiding this comment.
Oh, cool! Forgot I was using docker at some point! Thanks for this!
| defp error_message(%MXError{} = e), do: MXError.message(e) | ||
| defp error_message(msg), do: msg | ||
| defp error_message(msg) do | ||
| if Exception.exception?(msg) do |
Contributor
There was a problem hiding this comment.
That looks perfect! Unfortunately they don't have a defguard for it on elixir, it would be a lot more idiomatic if you could use when Exception.exception?(msg) on a guard, but it's not possible as it is now. I'll open a PR to Elixir core and check if they accept it though.
Contributor
|
PS.: the coverage went down because the overall line quantity went down. So we can merge and release a new rc for it. |
Contributor
|
This fixes #65 |
mgiacomini
approved these changes
Mar 7, 2019
mgiacomini
approved these changes
Mar 7, 2019
Contributor
Author
|
Just wanted to say thanks for all the work on Triplex! Its made my life much easier. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an error when compiling a dependent project that only has
postgrexas a dependency, due to the error struct pattern matching. I removed this logic in favor ofException.message/1.