Apply where, order, and limit in the right order in TestDriver #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the TestDriver will go through all entries, add entries that match the WHERE condition to the results until the LIMIT is reached, and then sort the result. This produces incorrect results, since the matching models should be sorted before the limit is applied.
Old behavior:
[0, 1, 2, 3, 4, 5, 6, 7]->SELECT * FROM ... LIMIT 3 ORDER BY num DESC->[2, 1, 0]Correct behavior:
[0, 1, 2, 3, 4, 5, 6, 7]->SELECT * FROM ... LIMIT 3 ORDER BY num DESC->[7, 6, 5]