Allow choice of rotation; clockwise/anticlockwise #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks mal, this is a very useful option - just the thing I was after! It would be nice (and consistent) if the direction value could also be passed in the options object when initialising knob() - for me this is just working when it's a data attribute on the input. |
Contributor
Author
|
Thanks @andfinally, I hadn't realised that didn't work. I've fixed it now, and also changed the setting name to |
Fixes aterrien#105 Creates the `rotation` option that allows a setting of `anticlockwise` (or 'acw') to reverse the direction of progression used by the knob. It fully supports the clicking/touching and `displayPrevious` functionality. To facilitate extending this behavior to custom draw functions, arc calculations have been factored out of `draw` into an `arc` function, which returns the start and end angles, and a boolean denoting the direction of the stroke.
|
Great, thanks! |
|
Any possibility to see this pull merged ? |
Contributor
Author
|
@aterrien any pointers for making this acceptable for merging? |
Owner
|
Thank you @mal (sorry, I was in the outer space). |
Contributor
Author
|
Thanks! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Creates the
rotationoption that allows a setting ofanticlockwise(oracw) to reverse the direction of progression used by the knob. It fully supports the clicking/touching anddisplayPreviousfunctionality.To facilitate extending this behavior to custom draw functions, arc calculations have been factored out of
drawinto anarcfunction, which returns the start and end angles, and a boolean denoting the direction of the stroke.I've tested it successfully using all of the examples founds on index.html and have added the option to one of the existing examples.
Tested in: Firefox 26, Chrome 32 and on Android 4.4 (Chrome).