Add a knob to the widget #195
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to optionally have a knob above the stroke. It reduces the whole widget radius if activated, or the knob would overflow the canvas. The knob's own radius must be expressed as a percentage of the ```lineWidth``` ( 0 < r < 1 ). If no ```knobRadius``` config argument is given, the value is set to ```0``` to avoid adding special cases further in the code for users that don't use it.
Previous commit #8be26fb211438e8d9c3b772363250ad4f11fb9a3 was misguided by non agnostic development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to optionally have a knob above the stroke.
Configuration :
displayKnob: boolean to display the knob or not. Default to false to be backward compatibleknobColor: (optionnal) background color of the knob, default tofgColorknobRadius: (required) must be expressed as a fractino of thelineWidth. Default to0in order to avoid having special cases further in the code.Notes : It reduces the whole widget radius if activated, or the knob would overflow the canvas.