Skip to content

Added Right-To-Left text direction support. #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Added Right-To-Left text direction support. #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ebd3dd
Added Right-To-Left text direction support.
johnallers May 7, 2014
ca3da3c
Minor refactoring to eliminate redundant margin calculation.
johnallers May 7, 2014
9133ad7
Added rtl option to the docs.
johnallers May 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ UI :
* font : font family.
* fontWeight : font weight.
* bgColor : background color.
* rtl : default=false | true=displays the input properly for right-to-left languages (Arabic, Hebrew, etc.). Requires displayInput=true.

Hooks
-------
Expand Down
9 changes: 7 additions & 2 deletions js/jquery.knob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
inline : false,
step : this.$.data('step') || 1,
rotation: this.$.data('rotation'),
rtl: false,

// Hooks
draw : null, // function () {}
Expand Down Expand Up @@ -700,13 +701,12 @@
) + 2;

this.o.displayInput
&& this.i.css({
&& (this.i.css({
'width' : ((this.w / 2 + 4) >> 0) + 'px'
,'height' : ((this.w / 3) >> 0) + 'px'
,'position' : 'absolute'
,'vertical-align' : 'middle'
,'margin-top' : ((this.w / 3) >> 0) + 'px'
,'margin-left' : '-' + ((this.w * 3 / 4 + 2) >> 0) + 'px'
,'border' : 0
,'background' : 'none'
,'font' : this.o.fontWeight + ' ' + ((this.w / s) >> 0) + 'px ' + this.o.font
Expand All @@ -715,6 +715,11 @@
,'padding' : '0px'
,'-webkit-appearance': 'none'
})
&& this.i.css(
this.o.rtl ? 'margin-right' : 'margin-left'
, '-' + ((this.w * 3 / 4 + 2) >> 0) + 'px'
)
)
|| this.i.css({
'width' : '0px'
,'visibility' : 'hidden'
Expand Down