Moved to attaching touch* and mouse* move/end events on the canvas #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the canvas Moved to attaching touchmove/touchend and mousemove/mouseend events on the canvas instead of on the document, so that the events can be prevented from propagating if needed
Author
|
Also see the pull request here - #298 |
Author
|
Closing as this will not provide a nice user experience because of having to only draw within the knob - you can't move outside the canvas while editing the knob if this is applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to attaching touchmove/touchend and mousemove/mouseend events on the canvas instead of on the document, so that the events can be prevented from propagating if needed.
Tested on IE, Chrome, Android & iOS.