Optimized rendering on Multicore OCaml #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream
Owner
|
Neat! I'll give this a run later today. |
Owner
|
Cool, it's much faster now! |
Contributor
Author
|
That's some nice numbers :) The hand-tuning part is just because there are no parallel libraries (that I know of) built on top of Multicore yet - can and will be done at a later stage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization is based on suggestions from one of the Multicore OCaml developers: https://discuss.ocaml.org/t/multicore-ocaml-march-2020-update/5406/9?u=rand
.. in essense, one spawns a
Domainper core, and communicates work and results through e.g. aChannelWould be interesting at a later time to implement the MPL 'ForkJoin' interface (or something else) on top of Multicore for having a simpler way of parallelizing
I also tried to optimize the
mk_bvhfunction, but need to learn a bit more about the new effect-systems typing to solve that one. There something like the 'ForkJoin' interface is even more useful.