Skip to content

Fix the Find bar overlay and match highlighting #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DeepanshuMishraa wants to merge 7 commits into from
Closed

Fix the Find bar overlay and match highlighting #311

DeepanshuMishraa wants to merge 7 commits into from

Conversation

@DeepanshuMishraa
Copy link
Contributor

@DeepanshuMishraa DeepanshuMishraa commented Aug 20, 2025 •
edited
Loading

Pull Request

Description

  • Fixed find bar input visibility by resolving black overlay that was hiding text input
  • Implemented search term highlighting in editor with yellow background for matches and orange for current match
  • Fixed text leaking from find bar to editor by adding proper event isolation and focus management
  • Optimized search navigation performance by improving decoration updates and using instant scrolling
  • Added proper cleanup of search decorations when find bar is closed to prevent visual artifacts

Command bar changes:

  • Added node_modules + build dirs to ignore patterns
  • Simplified fuzzy matching algorithm
  • Limited results to 50 for performance
  • Stricter matching criteria

Screenshots/Videos

screenrecording-2025-08-21_00-38-10.mp4

Related Issues

Closes #310

kovsu
kovsu reviewed Aug 21, 2025
View reviewed changes
src/components/command/components/command-bar.tsx Outdated
if (isVisible) {
setQuery("");
setSelectedIndex(0);
setIsLoadingFiles(files.length === 0); // Only show loading if no files cached
Copy link
Contributor

@kovsu kovsu Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only show loading if no files cached

🤨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mehmetozguldev mehmetozguldev Awaiting requested review from mehmetozguldev

@devkokooo devkokooo Awaiting requested review from devkokooo

1 more reviewer

@kovsu kovsu kovsu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Find bar input field hidden by black overlay and search term highlighting not working

3 participants

@DeepanshuMishraa @kovsu