Skip to content

Recognize ACP registry agent icons#681

Closed
Finesssee wants to merge 2 commits into
athasdev:masterfrom
Finesssee:codex/acp-provider-icons
Closed

Recognize ACP registry agent icons#681
Finesssee wants to merge 2 commits into
athasdev:masterfrom
Finesssee:codex/acp-provider-icons

Conversation

@Finesssee
Copy link
Copy Markdown
Contributor

@Finesssee Finesssee commented May 9, 2026

Summary

  • Prefer secure catalog-provided icons for ACP agents when marketplace or registry metadata includes one
  • Keep legacy ACP marketplace IDs mapped to existing provider icons when no catalog icon is available
  • Render ACP agent icons in the agent selector and Extensions settings list
  • Add focused coverage for registry icon URLs and legacy/current marketplace ID fallbacks

Test Plan

  • bunx vp test run src/features/ai/tests/provider-icons.test.ts
  • bun typecheck
  • git diff --check

Notes

  • This is frontend-only and does not change catalog loading, installation, or runtime behavior.

@mehmetozguldev mehmetozguldev self-requested a review May 10, 2026 10:20
@Finesssee
Copy link
Copy Markdown
Contributor Author

Superseded by #682. The ACP runtime/catalog branch now includes the newer provider icon/logo handling and records this branch as superseded, so this PR no longer needs to land separately.

@Finesssee
Copy link
Copy Markdown
Contributor Author

Closing as superseded by #682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant