Clarify ACP provider setup failures#684
Closed
Finesssee wants to merge 8 commits into
Closed
Conversation
Merge registry agents ahead of the legacy Athas marketplace catalog while preserving legacy-only entries as fallback options. Add agentServers settings support for custom agents and registry env/default overrides, and apply configured defaults through ACP session controls when available. Cover catalog precedence, custom agent mapping, env/default overrides, malformed local entries, and settings import/normalization with focused tests.
Contributor
Author
|
Superseded by #682. I folded the provider setup/error classification work into the ACP runtime/catalog PR so the ACP stack now lands through one resolved branch. |
Contributor
Author
|
Closing as superseded by #682, which now includes this provider setup/error UX work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authentication_requiredorprovider_setup_requiredbefore emitting them to the frontend.glm-acp-agent --setupwithout pulling surrounding prose into the command.Validation
cargo test -p athas-ai acp::bridge::testscargo test -p athas-ai acpcargo test -p athas acpbunx vp test run src/features/ai/tests/acp-provider-errors.test.ts src/features/ai/tests/error-block-parsing.test.tsbun typecheckgit diff --checkStack
Draft because this stacks on #678. Once #678 lands, retarget/rebase this PR against
masterso the diff only shows the provider setup/error UX follow-up.