Preserves "Dirty" flags for afterSave hooks.#72
Merged
Conversation
| * | ||
| * @return $this | ||
| */ | ||
| public $_dirty_after_reload = []; |
Member
There was a problem hiding this comment.
should be defined at top of Model class file.
Member
Author
There was a problem hiding this comment.
i thought since it's $_xx and we don't want anyone to use it but can't make it "private" due to our other class referring to it and also because our style checkers didn't complain, then we can leave here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using afterSave hooks you might be interested to look at the dirty fields. Unfortunately using the "reload after save" mechanics will cause it to reload the record which resets dirty fields.
This fix:
Goal of this PR:
No test-scripts provided for the above cases.