feat: add CorrelationContextInterceptor for atlan-* field propagation #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o activities Adds a new Temporal interceptor that propagates atlan-* correlation context fields (like atlan-ignore, atlan-argo-workflow-id, atlan-argo-workflow-node) from workflow arguments to all activities via Temporal headers. This ensures all activity logs include correlation identifiers, fixing the issue where activities like cleanup and publish_event were missing these fields. Changes: - Add CorrelationContextInterceptor with workflow inbound/outbound and activity inbound interceptors - Register as first interceptor in temporal.py - Remove redundant correlation context handling from events.py and workflows/__init__.py - Add comprehensive unit tests
saig214
requested review from
AtMrun,
firecast and
inishchith
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add CorrelationContextInterceptor to propagate atlan-* fields to activities and refactor correlation handling.
Changes
Test plan
Note
Adds a Temporal interceptor to propagate atlan-* fields from workflow args to activity headers, wires it into the worker, and removes ad-hoc correlation handling with unit tests.
CorrelationContextInterceptorwith workflow inbound/outbound and activity inbound interceptors to extractatlan-*from workflow args and inject/read them via Temporal headers (application_sdk/interceptors/correlation_context.py).CorrelationContextInterceptor()in workerinterceptors(application_sdk/clients/temporal.py).EventActivityInboundInterceptorandWorkflowInterface.run(application_sdk/interceptors/events.py,application_sdk/workflows/__init__.py).tests/unit/interceptors/test_correlation_context.py).Written by Cursor Bugbot for commit 743641f. This will update automatically on new commits. Configure here.