Conversation
Adds hand-authored overlay files in `_overlays/` for ~90 asset types and 4 interfaces (ICatalog, IModel, IMultiDimensionalDataset, IS3). These overlays provide custom method implementations that supplement or override generated code during the Pkl-based Java code generation pipeline. Also bumps `gradle.properties` version as part of this release. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Deletes the old `generate/` module, all `sdk/src/main/java/com/atlan/generators/` classes, all `sdk/src/main/resources/templates/` Freemarker templates, and the `samples/standalone/sdk-extension/` sample that depended on the generator API. Also removes the `freemarker` dependency from the SDK and excludes the new `_overlays/` snippet directory from Java compilation (those files are partial code snippets for the upcoming Pkl-based generator pipeline, not standalone classes). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
cmgrote
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1: Add asset overlay stubs
sdk/src/main/java/com/atlan/model/assets/_overlays/for ~90 asset types (e.g.Asset,Column,Glossary,Connection,DataProduct, etc.)ICatalog,IModel,IMultiDimensionalDataset,IS3Phase 2: Remove Freemarker-based code generator
generate/module (ModelGeneratorV2and supporting code)sdk/src/main/java/com/atlan/generators/(18 generator classes)sdk/src/main/resources/templates/(~124.ftlFreemarker templates)samples/standalone/sdk-extension/(depended directly on generator API)freemarkerdependency from the SDKsettings.gradle.kts,gradle/libs.versions.toml,CLAUDE.md, andREADME.mdaccordingly_overlays/snippet files from Java compilation (they are partial code fragments for the Pkl pipeline, not standalone classes)Test plan
./gradlew :sdk:assemble :sdk:shadowJar./gradlew :sdk:test🤖 Generated with Claude Code