Conversation
The old ModelGeneratorV2 accidentally placed copies of the DbtTest concrete class and IDbtTest interface into src/test/java alongside the authoritative versions in src/main/java. Because the test compilation source set includes both trees, the stale test-tree copies shadow the correctly-maintained main-tree versions. When the Pkl sync (PR #2415) added catalogDatasetGuid to DbtTest.java in src/main/java, the stale src/test/java/DbtTest.java (without the field) continued to be compiled by compileTestJava, producing: DbtTest.java:42: error: DbtTest is not abstract and does not override abstract method getCatalogDatasetGuid() in IDbt The canonical files in src/main/java are generated and maintained by the Pkl renderer; the test-tree copies serve no purpose. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DbtTest.javaandIDbtTest.javafromsrc/test/java— the oldModelGeneratorV2accidentally placed copies of both in the test source tree alongside the authoritative versions insrc/main/javaWhy this breaks
DbtTestis a real leaf asset type. The Pkl sync (PR #2415) correctly updatessrc/main/java/com/atlan/model/assets/DbtTest.javawith the newcatalogDatasetGuidfield. But the stalesrc/test/javacopy (without the field) is also compiled bycompileTestJava, shadowing the updated version and producing:Relationship to prior cleanup
Follows PR #2414 which removed 9 stale concrete classes/interfaces for
interfaceOnlyTypes. This is a different flavour:DbtTestis not aninterfaceOnlyType— it's a genuine leaf type whose concrete class just happened to be duplicated into the test tree by the old generator.Test plan
./gradlew assemble shadowJarpasses./gradlew testpasses