Conversation
…/purge tests The Atlan backend now returns cascading side-effected assets in the UPDATE bucket of delete responses (e.g. parent glossary updated when a term is soft-deleted). Asserting that updatedAssets is empty after a delete was never meaningful for verifying delete success — the correct signal is that getDeletedAssets() contains the expected asset. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UPDATEbucket of delete responses around April 10, 2026 (e.g. parent glossary appears inupdatedAssetswhen a child term is soft-deleted)assertTrue(response.getUpdatedAssets().isEmpty())andassertEquals(response.getUpdatedAssets().size(), 0)assertions from all delete/purge test methods across 20 test filesgetDeletedAssets().size(), asset GUID/qualifiedName, statusDELETED, and deleteHandler — are all preservedFixes: BLDX-1041
Test plan
AssertionError: expected [true] but found [false]🤖 Generated with Claude Code