Skip to content

fix(tests): remove overly strict updatedAssets assertions from delete/purge tests#2418

Merged
cmgrote merged 1 commit intomainfrom
BLDX-1041
Apr 17, 2026
Merged

fix(tests): remove overly strict updatedAssets assertions from delete/purge tests#2418
cmgrote merged 1 commit intomainfrom
BLDX-1041

Conversation

@cmgrote
Copy link
Copy Markdown
Collaborator

@cmgrote cmgrote commented Apr 17, 2026

Summary

  • The Atlan backend started returning cascading side-effected assets in the UPDATE bucket of delete responses around April 10, 2026 (e.g. parent glossary appears in updatedAssets when a child term is soft-deleted)
  • Removed assertTrue(response.getUpdatedAssets().isEmpty()) and assertEquals(response.getUpdatedAssets().size(), 0) assertions from all delete/purge test methods across 20 test files
  • Retained these assertions in create-operation methods where they remain valid (GlossaryTest, ConnectionTest, PersonaTest, PurposeTest, AtlanLiveTest, ModelTest)
  • The meaningful delete-success signals — getDeletedAssets().size(), asset GUID/qualifiedName, status DELETED, and deleteHandler — are all preserved

Fixes: BLDX-1041

Test plan

  • Integration tests should now pass for all delete/purge methods that were previously failing with AssertionError: expected [true] but found [false]
  • Create-operation assertions remain unchanged and unaffected

🤖 Generated with Claude Code

…/purge tests

The Atlan backend now returns cascading side-effected assets in the UPDATE
bucket of delete responses (e.g. parent glossary updated when a term is
soft-deleted). Asserting that updatedAssets is empty after a delete was
never meaningful for verifying delete success — the correct signal is that
getDeletedAssets() contains the expected asset.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
@cmgrote cmgrote merged commit daa8e43 into main Apr 17, 2026
7 checks passed
@cmgrote cmgrote added the bug Something isn't working label Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant