fix(tests): fix integration test assertions broken by server-side response format changes#2419
Conversation
…tion The Atlan backend no longer eagerly populates relationship attributes (inputs/outputs on LineageProcess, denyAssetTabs on Persona/Purpose, badgeConditions on Badge) in mutation responses. Verify these via an explicit read-back instead of from the mutation response payload. Also relaxes the strict updatedAssets count assertion in lineage tests to presence-only checks (the server may now return additional cascading updates), and drops the validateSingleUpdate assertion from purgeAtlanTags which is a cleanup step that doesn't need response structure validation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updatedAssets.isEmpty()/updatedAssets.size() == 0assertions from all delete/purge test methods — the Atlan backend now returns cascading side-effected assets in theUPDATEbucket of delete responses (server-side change ~April 10, 2026)inputs/outputs,denyAssetTabs,badgeConditions) directly from mutation responses — these are no longer eagerly populated by the server; tests now do an explicit read-back to validate themupdatedAssetscount assertions in lineage tests to GUID-presence checks, since the server may return additional cascading updatesFixes: BLDX-1041
Changed tests
Delete/purge assertions (45 lines removed across 20 files):
ADLSAssetTest, APIAssetTest, AirflowAssetTest, AnaplanAssetTest, AppAssetTest, AzureEventHubTest, CustomAssetTest, CustomMetadataTest, DataStudioAssetTest, DataverseAssetTest, FileTest, GCSAssetTest, GlossaryTest, InsightsTest, KafkaTest, PresetAssetTest, S3AssetTest, SQLAssetTest, SupersetAssetTest, TableSearchTest
Read-back fixes:
LineageTest.createLineageStart/End—LineageProcess.get(guid, true)to verifyinputs/outputsPersonaTest.updatePersonas—Persona.get(qualifiedName, true)to verifydenyAssetTabsPurposeTest.updatePurposes—Purpose.get(qualifiedName, true)to verifydenyAssetTabsPurposeTest.purgeAtlanTags— removedvalidateSingleUpdate(cleanup step, no response assertion needed)CustomMetadataTest.createBadges—Badge.get(guid, true)for each of 4 badges to verifybadgeConditionsTest plan
expected [true] but found [false]on empty updatedAssets)🤖 Generated with Claude Code