Skip to content

Adds shortcuts to create custom metadata properties#50

Merged
ErnestoLoma merged 17 commits intomainfrom
ACTIV-557
May 18, 2023
Merged

Adds shortcuts to create custom metadata properties#50
ErnestoLoma merged 17 commits intomainfrom
ACTIV-557

Conversation

@cmgrote
Copy link
Copy Markdown
Collaborator

@cmgrote cmgrote commented May 12, 2023

No description provided.

cmgrote added 3 commits May 12, 2023 18:29
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote cmgrote requested a review from ErnestoLoma May 12, 2023 17:35
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote cmgrote removed the request for review from ErnestoLoma May 15, 2023 09:49
@cmgrote
Copy link
Copy Markdown
Collaborator Author

cmgrote commented May 15, 2023

Actually, don't review / merge this yet — will incorporate the more extensive integration test, first.

cmgrote added 3 commits May 15, 2023 14:02
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
@cmgrote cmgrote requested a review from ErnestoLoma May 17, 2023 01:07
cmgrote added 2 commits May 17, 2023 02:25
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@ErnestoLoma ErnestoLoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent you a meeting request so we can discuss how we might have a more pythonic integration tests. Let me know if there's a better time for you.

Comment thread pyatlan/client/atlan.py Outdated
Comment thread pyatlan/model/typedef.py Outdated
Comment thread pyatlan/model/typedef.py Outdated
Comment thread pyatlan/model/typedef.py Outdated
Comment thread pyatlan/model/typedef.py Outdated
Comment thread tests/integration/classification_test.py Outdated
Comment thread tests/integration/classification_test.py Outdated
Comment thread tests/integration/classification_test.py Outdated
Comment thread tests/integration/custom_metadata_test.py
Comment thread tests/integration/custom_metadata_test.py
cmgrote and others added 8 commits May 17, 2023 11:05
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
Signed-off-by: Christopher Grote <cmgrote@users.noreply.github.com>
…a different client until they can be refactored
Copy link
Copy Markdown
Contributor

@ErnestoLoma ErnestoLoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Contributor

@ErnestoLoma ErnestoLoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Contributor

@ErnestoLoma ErnestoLoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ErnestoLoma ErnestoLoma merged commit 670d1ce into main May 18, 2023
@ErnestoLoma ErnestoLoma deleted the ACTIV-557 branch May 18, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants