APP-9677: Fixed type for LineageListRequest.relation_attributes to be Optional[List[str]]#759
Merged
Aryamanz29 merged 1 commit intomainfrom Nov 10, 2025
Merged
APP-9677: Fixed type for LineageListRequest.relation_attributes to be Optional[List[str]]#759Aryamanz29 merged 1 commit intomainfrom
LineageListRequest.relation_attributes to be Optional[List[str]]#759Aryamanz29 merged 1 commit intomainfrom
Conversation
…be `Optional[List[str]]`
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for relation attributes in lineage queries by introducing the includes_on_relations parameter to FluentLineage and fixing the type of relation_attributes in LineageListRequest.
- Fixed
relation_attributesfield type fromOptional[str]toOptional[List[str]]inLineageListRequest - Added
includes_on_relationsparameter support toFluentLineagefor specifying attributes to retrieve on related assets - Added comprehensive test coverage for the new
includes_on_relationsfunctionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyatlan/model/lineage.py | Fixed relation_attributes type from str to List[str] to correctly represent a list of attributes |
| tests/unit/test_lineage.py | Added import for LineageListRequest, corrected variable naming from GOOD_INCLUDE_ON_RESULTS to GOOD_INCLUDES_ON_RESULTS, added GOOD_INCLUDES_ON_RELATIONS constant, updated all test cases to include the new parameter, and added new test test_init_and_request_for_includes_on_relations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://atlanhq.atlassian.net/browse/APP-9677
Closes #756
🧩 Type of change
Select all that apply:
Note
Change
LineageListRequest.relation_attributestoOptional[List[str]]and propagate viaFluentLineage.includes_on_relations, with corresponding unit test updates.LineageListRequest.relation_attributestype fromOptional[str]toOptional[List[str]].request.relation_attributesfromincludes_on_relations(supportsstr,AtlanField, or lists).LineageListRequestand new cases validatingrelation_attributespopulation.includes_on_relations.Written by Cursor Bugbot for commit 581640d. This will update automatically on new commits. Configure here.