Skip to content

APP-9677: Fixed type for LineageListRequest.relation_attributes to be Optional[List[str]]#759

Merged
Aryamanz29 merged 1 commit intomainfrom
APP-9677
Nov 10, 2025
Merged

APP-9677: Fixed type for LineageListRequest.relation_attributes to be Optional[List[str]]#759
Aryamanz29 merged 1 commit intomainfrom
APP-9677

Conversation

@Aryamanz29
Copy link
Copy Markdown
Member

@Aryamanz29 Aryamanz29 commented Nov 10, 2025

https://atlanhq.atlassian.net/browse/APP-9677

Closes #756

🧩 Type of change

Select all that apply:

  • 🚀 New feature (non-breaking change that adds functionality)
  • 🐛 Bug fix (non-breaking change that fixes an issue) — please include tests! Refer testing-toolkit 🧪
  • 🔄 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🧹 Maintenance (chores, cleanup, minor improvements)
  • 💥 Breaking change (fix or feature that may break existing functionality)
  • 📦 Dependency upgrade/downgrade
  • 📚 Documentation updates

Note

Change LineageListRequest.relation_attributes to Optional[List[str]] and propagate via FluentLineage.includes_on_relations, with corresponding unit test updates.

  • Lineage model:
    • Change LineageListRequest.relation_attributes type from Optional[str] to Optional[List[str]].
  • FluentLineage:
    • Populate request.relation_attributes from includes_on_relations (supports str, AtlanField, or lists).
  • Tests:
    • Add import for LineageListRequest and new cases validating relation_attributes population.
    • Extend bad-parameter validations to cover includes_on_relations.
    • Minor variable renames to align with new fields.

Written by Cursor Bugbot for commit 581640d. This will update automatically on new commits. Configure here.

@Aryamanz29 Aryamanz29 requested a review from Copilot November 10, 2025 10:05
@Aryamanz29 Aryamanz29 self-assigned this Nov 10, 2025
@Aryamanz29 Aryamanz29 added the bugfix Bug fix pull request label Nov 10, 2025
@Aryamanz29 Aryamanz29 merged commit 1818397 into main Nov 10, 2025
15 of 20 checks passed
@Aryamanz29 Aryamanz29 deleted the APP-9677 branch November 10, 2025 10:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for relation attributes in lineage queries by introducing the includes_on_relations parameter to FluentLineage and fixing the type of relation_attributes in LineageListRequest.

  • Fixed relation_attributes field type from Optional[str] to Optional[List[str]] in LineageListRequest
  • Added includes_on_relations parameter support to FluentLineage for specifying attributes to retrieve on related assets
  • Added comprehensive test coverage for the new includes_on_relations functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pyatlan/model/lineage.py Fixed relation_attributes type from str to List[str] to correctly represent a list of attributes
tests/unit/test_lineage.py Added import for LineageListRequest, corrected variable naming from GOOD_INCLUDE_ON_RESULTS to GOOD_INCLUDES_ON_RESULTS, added GOOD_INCLUDES_ON_RELATIONS constant, updated all test cases to include the new parameter, and added new test test_init_and_request_for_includes_on_relations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/unit/test_lineage.py
Comment thread tests/unit/test_lineage.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Incorrect type alias for LineageListRequest.relation_attributes

2 participants