Skip to content

APP-10274: Generated latest typedef models#774

Merged
Aryamanz29 merged 2 commits intomainfrom
APP-10274
Dec 15, 2025
Merged

APP-10274: Generated latest typedef models#774
Aryamanz29 merged 2 commits intomainfrom
APP-10274

Conversation

@Aryamanz29
Copy link
Copy Markdown
Member

@Aryamanz29 Aryamanz29 commented Dec 15, 2025

✨ Description

https://atlanhq.atlassian.net/browse/APP-10274

🧩 Type of change

Select all that apply:

  • 🚀 New feature (non-breaking change that adds functionality)
  • 🐛 Bug fix (non-breaking change that fixes an issue) — please include tests! Refer testing-toolkit 🧪
  • 🔄 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🧹 Maintenance (chores, cleanup, minor improvements)
  • 💥 Breaking change (fix or feature that may break existing functionality)
  • 📦 Dependency upgrade/downgrade
  • 📚 Documentation updates

✅ How has this been tested? (e.g. screenshots, logs, workflow links)

Describe how the change was tested. Include:

  • Steps to reproduce
  • Any relevant screenshots, logs, or links to successful workflow runs
  • Details on environment/setup if applicable

📋 Checklist

  • My code follows the project’s style guidelines
  • I’ve performed a self-review of my code
  • I’ve added comments in tricky or complex areas
  • I’ve updated the documentation as needed
  • There are no new warnings from my changes
  • I’ve added tests to cover my changes
  • All new and existing tests pass locally

Note

Adds new AtlanApp and SageMaker Unified Studio asset types, introduces Partial/PartialV02 models and relations, replaces GCP Dataplex fields with SMUS metadata, adds DQ custom SQL return type, and removes catalog_has_partial_fields across assets with docs updates.

  • Models/Assets:
    • Add AtlanApp, AtlanAppDeployment, AtlanAppInstalled.
    • Add SageMaker Unified Studio assets: SageMakerUnifiedStudio, SageMakerUnifiedStudioProject, SageMakerUnifiedStudioAsset, SageMakerUnifiedStudioAssetSchema, SageMakerUnifiedStudioPublishedAsset, SageMakerUnifiedStudioSubscribedAsset.
    • Add Partial, PartialField, PartialObject, plus PartialV02, PartialV02Field, PartialV02Object with relations in Catalog, DataStudio, GCS.
  • Core changes:
    • Replace GCP Dataplex fields on Asset with SMUS metadata: assetSmusMetadataFormNames, assetSmusMetadataFormKeyValueDetails, assetSmusMetadataFormDetails.
    • Add MongoDB relations between Column/DremioColumn and MongoDBCollection; expose mongoDBColumns on MongoDBCollection and CosmosMongoDBCollection.
  • Data Quality:
    • Add dqRuleCustomSQLReturnType (enum DataQualityRuleCustomSQLReturnType) to DataQualityRule.
  • Structs/Enums:
    • Add AssetSmusMetadataFormDetails struct and enums AssetSmusMetadataFormStatus, AtlanAppDeploymentOperation, AtlanAppDeploymentStatus, SageMakerUnifiedStudioProjectStatus.
  • Removals/Cleanup:
    • Remove catalogHasPartialFields from numerous assets; minor refactors and forward-ref updates.
  • Docs:
    • Add RST pages for new assets (docs/asset/*) and include them in docs/assets.rst.

Written by Cursor Bugbot for commit 9af631c. This will update automatically on new commits. Configure here.

@Aryamanz29 Aryamanz29 requested a review from Copilot December 15, 2025 08:43
@Aryamanz29 Aryamanz29 self-assigned this Dec 15, 2025
@Aryamanz29 Aryamanz29 added the feature New feature or request label Dec 15, 2025
@Aryamanz29 Aryamanz29 merged commit 21654eb into main Dec 15, 2025
59 of 61 checks passed
@Aryamanz29 Aryamanz29 deleted the APP-10274 branch December 15, 2025 08:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the typedef models by regenerating them from the latest type definitions. The changes primarily involve adding new asset types for AWS SageMaker Unified Studio and AtlanApp, introducing a new Partial asset hierarchy to replace deprecated GCP Dataplex metadata handling, and updating several existing assets with new relationships and fields.

Key Changes:

  • Added new AWS SageMaker Unified Studio asset hierarchy (5 new classes)
  • Introduced new Partial asset types (v01, v02, Field, Object) for handling incomplete/partial asset metadata
  • Added AtlanApp deployment tracking assets
  • Removed deprecated catalog_has_partial_fields boolean field across all assets, replaced with relationship-based partial field tracking
  • Added new enums for SMUS metadata forms, AtlanApp deployments, and data quality rules
  • Updated Asset base class to use SMUS metadata instead of GCP Dataplex metadata

Reviewed changes

Copilot reviewed 77 out of 77 changed files in this pull request and generated 15 comments.

Show a summary per file
File Description
pyatlan/model/structs.py Added new structs (AssetExternalDQTestMetric, AssetSmusMetadataFormDetails) and reordered existing struct definitions
pyatlan/model/enums.py Added 5 new enum types for SMUS forms, AtlanApp operations/status, and DQ rule types
pyatlan/model/assets/sage_maker_unified_studio*.py New SageMaker Unified Studio asset hierarchy with 5 classes
pyatlan/model/assets/core/partial*.py New Partial asset types (6 classes) for handling incomplete asset metadata
pyatlan/model/assets/atlan_app*.py New AtlanApp deployment tracking assets (3 classes)
pyatlan/model/assets/core/catalog.py Removed catalog_has_partial_fields boolean, added 4 new partial relationship fields
pyatlan/model/assets/core/asset.py Replaced GCP Dataplex metadata with SMUS metadata form details
Multiple asset files Systematic removal of catalog_has_partial_fields field across 30+ asset types
pyatlan/model/assets/core/mongo_d_b_collection.py Added mongoDBColumns relationship field
docs/*.rst Added documentation stubs for all new asset types

The changes appear to be machine-generated typedef updates that are internally consistent. No issues were identified that require comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

type_name: str = Field(default="AtlanApp", allow_mutation=False)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Suggested change
def validate_type_name(cls, v):
def validate_type_name(self, v):

Copilot uses AI. Check for mistakes.
type_name: str = Field(default="AtlanAppInstalled", allow_mutation=False)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Suggested change
def validate_type_name(cls, v):
def validate_type_name(self, v):

Copilot uses AI. Check for mistakes.

type_name: str = Field(default="AtlanAppDeployment", allow_mutation=False)

@validator("type_name")
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Suggested change
@validator("type_name")
@validator("type_name")
@classmethod

Copilot uses AI. Check for mistakes.
type_name: str = Field(default="PartialField", allow_mutation=False)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Copilot uses AI. Check for mistakes.
type_name: str = Field(default="PartialObject", allow_mutation=False)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Copilot uses AI. Check for mistakes.
type_name: str = Field(default="SageMakerUnifiedStudioAsset", allow_mutation=False)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Copilot uses AI. Check for mistakes.
)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Copilot uses AI. Check for mistakes.
)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Copilot uses AI. Check for mistakes.
)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Copilot uses AI. Check for mistakes.
)

@validator("type_name")
def validate_type_name(cls, v):
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal methods should have 'self', rather than 'cls', as their first parameter.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants