refactor: address review comments for GOVFOUN-408 pool timeout fix#913
Merged
Conversation
- Extract _DEFAULT_POOL_LIMITS and _DEFAULT_POOL_TIMEOUT_SECONDS constants to eliminate duplication across init, reset, max_retries, and timeout - Log old session close failure at DEBUG instead of bare except pass - Change reset_http_session log from WARNING to INFO (expected recovery) - Add resilient _get_httpcore_pool helper with pytest.skip fallback - Update test assertions to reference constants instead of hardcoded values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #911 (GOVFOUN-408) which was merged before review fixes could be applied.
Changes
_DEFAULT_POOL_LIMITSand_DEFAULT_POOL_TIMEOUT_SECONDS— same Limits repeated 4x, now defined once at module levelexcept: pass→except as e: LOGGER.debug(...)LOGGER.warning→LOGGER.infoforreset_http_session()(expected recovery, not error)_get_httpcore_pooltest helper —pytest.skip()fallback if httpx internals changeTests
62/62 pass
🤖 Generated with Claude Code