[Jira] Deactivating a user not working

[JoeMcMahon87]

Using the API I make a call to jira.user_deactivate with the user name via an admin user and I get no errors, but when I log into the site, the user still has full site access. Is this method non-functional?

[gonchik]

Hi!

On which version did you test it?
in reality, I like to use the some rest endpoint.

Cheers,
Gonchik Tsymzhitov

[JoeMcMahon87]

atlassian-python-api==1.11.19

I'd prefer the Python API - are you saying that I should change over to the Rest endpoint instead?

[jefft]

I can confirm, user_deactivate() doesn't work in 1.13.7. The POST isn't even being sent.

The problem is on rest_client.py:107:

        if files is None:
            data = json.dumps(data)

I'm not sure what those lines are trying to achieve, but the effect is to convert data from a dict to a str. Then later, in oauthlib/common.py, we find that the body is assumed to be urlencoded, which ours isn't, and the code just returns None, so there's no decent errors, just a silent failure:

def extract_params(raw):
    """Extract parameters and return them as a list of 2-tuples.

    Will successfully extract parameters from urlencoded query strings,
    dicts, or lists of 2-tuples. Empty strings/dicts/lists will return an
    empty list of parameters. Any other input will result in a return
    value of None.
    """
    if isinstance(raw, bytes) or isinstance(raw, unicode_type):
        try:
            params = urldecode(raw)
        except ValueError:
            params = None

Commenting out those two lines fixes the immediate problem. The data is kept as a dict, not a str, and the relevant POST now gets sent.

Sadly even with this fix, user_deactivate() won't work, at least with oauth, because Jira websudo intercepts the request and demands an admin password. This can be seen by turning on debug logging (import logging; logging.basicConfig(level=logging.DEBUG)). I haven't had any luck manually calling user_get_websudo().

https://jira.atlassian.com/browse/JRASERVER-44801 says that the REST API call for deactivating users should be available in the next release (probably 8.2.2 or later). I suggest deferring till that is implemented.

For now, an option is to create a custom 'deactivate user' REST endpoint with ScriptRunner (see example; also Adaptavist's sample script to deactivate inactive users).

[SLRover]

Hello everyone! Currently methods of deactivation revoked in #229
We are waiting new feature in https://jira.atlassian.com/browse/JRASERVER-44801

[gonchik]

@SLRover Please, wait.
On my instance it works well :) Also, I have additional rest endpoint.
Better way to set as deprecated

[SLRover]

@gonchik Are you mean ScriptRunner endpoint? On my both instances (Jira 7 and Jira 8) this method don't work too.

[SLRover]

Hey, @gonchik! I reverted commit which exclude user deactivate methods in #229 pull request.
I hope, we find solution for deactivating users in Jira. 👍

[gonchik]

as I see on 8.3.0 will be supported by design :)

[gonchik]

Hi @SLRover ,
Let's deliver a new release and use the latest Jira version :)