setup.py script dependency on pywin32 breaks on Mac

[kmcquade]

I believe the setup.py modifications and kerberos integration introduced starting with this commit broke things for me. This includes the updated master branch.

See the output from the failed pip3 install below.

Collecting pywin32 (from kerberos-sspi->atlassian-python-api->-r requirements.txt (line 2))
  Could not find a version that satisfies the requirement pywin32 (from kerberos-sspi->atlassian-python-api->-r requirements.txt (line 2)) (from versions: )
No matching distribution found for pywin32 (from kerberos-sspi->atlassian-python-api->-r requirements.txt (line 2))

I had to put this in requirements.txt to make it work (note: the commit I am referring to is pre-Kerberos integration):

git+https://github.com/atlassian-api/atlassian-python-api@e14475ed3aca9de71c8a8954911d8c7a2a3942ea#egg=atlassian-python-api

I have a workaround right now but please fix. Thanks

[BrandtWoolf]

Can confirm I just ran into this as well.

Suggested workaround, to install from commit (e14475e) prior to PR #335, worked

[ResourceHog]

How do you do that?

[BrandtWoolf]

How do you do that?

$ pip install git+https://github.com/atlassian-api/atlassian-python-api@e14475ed3aca9de71c8a8954911d8c7a2a3942ea#egg=atlassian-python-api

[gsemet]

Yes, reproducted. Somehow the mac install_requires has kerberos-sspi instead of kerberos dependency.

The code is wrong, (['kerberos-sspi'] if "win" in sys.platform else ['kerberos']), only execute on the build platform. So this won't work on a universal wheel.

You need to use platform marker for that. See here

[johnsturgeon]

Thank you all.. just ran across this issue and your workarounds helped

[micahculpepper]

In addition to the Mac problem, the kerberos dependency adds a system library dependency on Linux. Without it, pip install atlassian-python-api fails with

  Building wheel for kerberos (setup.py): started
  Building wheel for kerberos (setup.py): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: /usr/bin/python3 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-wheel-m2863fhq/kerberos/setup.py'"'"'; __file__='"'"'/tmp/pip-wheel-m2863fhq/kerberos/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-htja_aux
       cwd: /tmp/pip-wheel-m2863fhq/kerberos/
  Complete output (14 lines):
  running bdist_wheel
  running build
  running build_ext
  building 'kerberos' extension
  creating build
  creating build/temp.linux-x86_64-3.7
  creating build/temp.linux-x86_64-3.7/src
  x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.7m -c src/base64.c -o build/temp.linux-x86_64-3.7/src/base64.o /bin/sh: 1: krb5-config: not found
  x86_64-linux-gnu-gcc: error: /bin/sh:: No such file or directory
  x86_64-linux-gnu-gcc: error: 1:: No such file or directory
  x86_64-linux-gnu-gcc: error: krb5-config:: No such file or directory
  x86_64-linux-gnu-gcc: error: not: No such file or directory
  x86_64-linux-gnu-gcc: error: found: No such file or directory
  error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for kerberos

The package to install is named libkrb5-dev on Debian. Maybe the docs for this library should make a note of this system dependency?

[gsemet]

#344 should fix this issue

[gonchik]

released as major release 1.14.0.
checked on macos, win and oracle linux. now it works well

[gsemet]

yes, works great :)