Skip to content

Issue 286: Confluence.get_page_by_title() works like Confluence.get_page_by_id() #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Issue 286: Confluence.get_page_by_title() works like Confluence.get_page_by_id() #288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e2d017
issue #286: remove useless parameter start and limit and add expand t…
Jul 23, 2019
96371a6
issue #286: fix a code inspector warning
Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions atlassian/confluence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,24 +92,23 @@ def get_page_space(self, page_id):
"""
return ((self.get_page_by_id(page_id, expand='space') or {}).get('space') or {}).get('key')

def get_page_by_title(self, space, title, start=None, limit=None):
def get_page_by_title(self, space, title, expand=None):
"""
Returns the list of labels on a piece of Content.
:param space: Space key
:param title: Title of the page
:param start: OPTIONAL: The start point of the collection to return. Default: None (0).
:param limit: OPTIONAL: The limit of the number of labels to return, this may be restricted by
fixed system limits. Default: 200.
:param expand: OPTIONAL: expand e.g. history
:return: The JSON data returned from searched results the content endpoint, or the results of the
callback. Will raise requests.HTTPError on bad input, potentially.
If it has IndexError then return the None.
"""
url = 'rest/api/content'
params = {}
if start is not None:
params['start'] = int(start)
if limit is not None:
params['limit'] = int(limit)
params = {
'start': '0',
'limit': '1'
}
if expand is not None:
params['expand'] = expand
if space is not None:
params['spaceKey'] = str(space)
if space is not None:
Expand Down