Skip to content

update_page should not require parent_id #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2016
Merged

update_page should not require parent_id #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9337000
Parent_id shouldn't be required for update_page
Feb 17, 2016
4f6803c
fixing a typo
Feb 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions atlassian/confluence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,21 +59,26 @@ def is_page_content_is_already_updated(self, page_id, body):
log.info('Content of {page_id} differs'.format(page_id=page_id))
return False

def update_page(self, parent_id, page_id, title, body, type='page'):
def update_page(self, parent_id=None, page_id, title, body, type='page'):
log.info('Updating {type} "{title}"'.format(title=title, type=type))
if self.is_page_content_is_already_updated(page_id, body):
return self.get_page_by_id(page_id)
else:
version = self.history(page_id)['lastUpdated']['number'] + 1
return self.put('/rest/api/content/{0}'.format(page_id), data={

data = {
'id': page_id,
'type': type,
'ancestors': [{'type': 'page', 'id': parent_id}],
'title': title,
'body': {'storage': {
'value': body,
'representation': 'storage'}},
'version': {'number': version}})
'version': {'number': version}}
}

if parent_id is not None:
data['ancestors']: [{'type': 'page', 'id': parent_id}]
return self.put('/rest/api/content/{0}'.format(page_id), data=data)

def update_or_create(self, parent_id, title, body):
space = self.get_page_space(parent_id)
Expand Down