update_page should not require parent_id #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you very much! :) |
astromatt
pushed a commit
that referenced
this pull request
Feb 18, 2016
update_page should not require parent_id
astromatt
added a commit
that referenced
this pull request
Apr 18, 2016
cattz
pushed a commit
to cattz/atlassian-python-api
that referenced
this pull request
Feb 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update_pagemethod in confluence should not require aparent_id. It looks like theexamples/confluence-update-page.pyalso isn't expecting a required parent_id.I've modified the method to work with a parent_id for old code, and not require it for new code (why I didn't move the named param with default value to the end).
Thanks!
Nick