Confluence: fix #412 #433
Merged
Confluence: fix #412 #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikitachab
suggested changes
Jan 24, 2020
| .get('body') or {}) | ||
| .get('storage') or {}) | ||
| if self.advanced_mode: | ||
| confluence_content = (((self.get_page_by_id(page_id, expand='body.storage').json() or {}) |
There was a problem hiding this comment.
Hi!
maybe better will be something like that:
page = self.get_page_by_id(page_id, expand='body.storage')
page = page.json() if self.advanced_mode else page
confluence_content = (((page or {})
.get('body') or {})
.get('storage') or {})it helps to avoid code duplication and makes code more readable.
| else: | ||
| try: | ||
| version = self.history(page_id)['lastUpdated']['number'] + 1 | ||
| if self.advanced_mode: |
There was a problem hiding this comment.
and the same here
page_history = self.history(page_id).json() if self.advanced_mode else self.history(page_id)
version = page_history['lastUpdated']['number'] + 1
Member
|
@mikitachab Would you like to provide a some PR for refactoring ? :) |
|
@gonchik no problem, I will find some time and do it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for an issue. I think we should make a review of the advanced_mode features for all methods.
It not the first time, when some troubles appear because of that.