[Confluence] Fix page title comparison #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chdwlch
force-pushed
the
bugfix/title-comparison
branch
from
600d85c to
e98f2ed
Compare
|
Good caught! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug that makes the Confluence library think that every page needs to be updated.
The 'title' key does not exist in the dictionary returned by get_page_by_id() with expand set to 'body.storage', so current_title in the title comparison always evaluates to None.
I moved the title check before the body check and removed the expanded option from get_page_by_id so we can access the correct title value.
Tested against Confluence 6.13.8