Skip to content

Conversation

@aregier
Copy link
Contributor

@aregier aregier commented Dec 7, 2020

No description provided.

Comment on lines 1950 to 1954
return self.resource_url(
"{}/branchmodel/configuration".format(self._url_repo(project_key, repository_slug)),
api_root="rest/branch-utils",
api_version="1.0",
"{}/branchmodel/configuration".format(self._url_repo(project_key, repository_slug, api_root="rest/branch-utils", api_version="1.0")),
api_root='',
api_version=''
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails because of formating. Following should work:

        return "{}/branchmodel/configuration".format(
            self._url_repo(
                project_key,
                repository_slug,
                api_root="rest/branch-utils",
                api_version="1.0",
            )
        )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Spacetown - Better code, too. :-)

Copy link
Contributor

@Spacetown Spacetown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@gonchik gonchik merged commit 40c70ad into atlassian-api:master Dec 17, 2020
@gonchik
Copy link
Member

gonchik commented Dec 17, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants