Skip to content

Conversation

@Spacetown
Copy link
Contributor

@Spacetown Spacetown commented Jan 1, 2021

Unify the OO implementations:

  • Remove checks for "error" in response because an exception is thrown on HTTP errors.
  • Moved delete from base class because of the API link. Always returns nothing.
  • Moved update from base class because of the API link. Always returns the updated objects (self).
  • Add missing link to API documentation always at the end and move existing links. Links always start with "API docs:".
  • Fixed relative links in Cloud pull request test mookup and use this links instead of building own links in code.
  • Fix update of properties for Server.

- Add links to API documentation
- Add update to cloud repository.
- Remove checks for "error" in response because an exception is thrown on HTTP errors.
@Spacetown Spacetown force-pushed the unifiy_bb_server_and_clode branch from 72bff06 to f97c318 Compare January 2, 2021 22:52
@Spacetown Spacetown marked this pull request as ready for review January 2, 2021 22:58
@gonchik gonchik self-requested a review January 3, 2021 18:01
@gonchik gonchik merged commit f1f8223 into atlassian-api:master Jan 3, 2021
@gonchik
Copy link
Member

gonchik commented Jan 3, 2021

Thank you! :)

@Spacetown Spacetown deleted the unifiy_bb_server_and_clode branch January 3, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants