Docs: Remove Key-Cert authentication info #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation gave information about authentication with key and certificate. This method cannot be found in the code and not in the Atlassian documentation. Therefore, the chapter is removed and the other authentication methods are grouped with a new title.
Spacetown
approved these changes
Jan 5, 2021
Contributor
Spacetown
left a comment
Spacetown
left a comment
There was a problem hiding this comment.
LGFM because the options are missing in
atlassian-python-api/atlassian/rest_client.py
Lines 37 to 54 in 6ffed81
Member
|
Thank you! :) |
at3560k
added a commit
to at3560k/atlassian-python-api
that referenced
this pull request
Apr 26, 2021
This is nearly a revert of 1b4ca92 / (atlassian-api#682) The previous information about authentication via key and certificate remains not directly supported, but the documentation can still demontsrate how to authenticate.
at3560k
added a commit
to at3560k/atlassian-python-api
that referenced
this pull request
Apr 26, 2021
This is nearly a revert of 1b4ca92 / (atlassian-api#682) The previous information about authentication via key and certificate remains not directly supported, but the documentation can still demontsrate how to authenticate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation gave information about authentication with key and certificate. I could not find this authentication method in the code and as well not in the Atlassian documentation.
Therefore, I removed the chapter is removed and the other authentication methods are grouped with a new title. Maybe you have more information what could be meant there?