Skip to content

Add Confluence update_page(always_update) and get_space(params) methods #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Add Confluence update_page(always_update) and get_space(params) methods #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions atlassian/confluence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,6 +1255,7 @@ def update_page(
representation="storage",
minor_edit=False,
version_comment=None,
always_update=False,
):
"""
Update page if already exist
Expand All @@ -1267,11 +1268,12 @@ def update_page(
:param minor_edit: Indicates whether to notify watchers about changes.
If False then notifications will be sent.
:param version_comment: Version comment
:param always_update: Whether always to update (suppress content check)
:return:
"""
log.info('Updating {type} "{title}"'.format(title=title, type=type))

if body is not None and self.is_page_content_is_already_updated(page_id, body, title):
if not always_update and body is not None and self.is_page_content_is_already_updated(page_id, body, title):
return self.get_page_by_id(page_id)

try:
Expand Down Expand Up @@ -1768,15 +1770,16 @@ def get_all_members(self, group_name="confluence-users", expand=None):
print("Did not get members from {} group, please check permissions or connectivity".format(group_name))
return members

def get_space(self, space_key, expand="description.plain,homepage"):
def get_space(self, space_key, expand="description.plain,homepage", params=None):
"""
Get information about a space through space key
:param space_key: The unique space key name
:param expand: OPTIONAL: additional info from description, homepage
:param params: OPTIONAL: dictionary of additional URL parameters
:return: Returns the space along with its ID
"""
url = "rest/api/space/{space_key}".format(space_key=space_key)
params = {}
params = params or {}
if expand:
params["expand"] = expand
try:
Expand Down