Skip to content

Conversation

@Spacetown
Copy link
Contributor

@gonchik Can the usage of f-strings be checked with flake8? I found nothing.

Closes #828

@codecov-commenter
Copy link

Codecov Report

Merging #830 (392e4f6) into master (e5bff44) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   35.73%   35.73%           
=======================================
  Files          32       32           
  Lines        6150     6150           
  Branches      890      890           
=======================================
  Hits         2198     2198           
  Misses       3854     3854           
  Partials       98       98           
Impacted Files Coverage Δ
atlassian/bitbucket/__init__.py 28.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5bff44...392e4f6. Read the comment docs.

@gonchik
Copy link
Member

gonchik commented Aug 4, 2021

@Spacetown found that one. flake8-no-unnecessary-fstrings .
But I did not find any source code, that's not good to me

@gonchik gonchik merged commit 2de3e26 into atlassian-api:master Aug 4, 2021
@Spacetown
Copy link
Contributor Author

Spacetown commented Aug 4, 2021

I also find only checks if a fstring has no code references. Thanks.

@Spacetown Spacetown deleted the remove_fstring branch February 2, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

version 3.12 introduced a small python < 3 issue by using an fstring

3 participants