Skip to content

Fix issue with start_index reset #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Fix issue with start_index reset #838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5b2b29
Fix issue with start_index reset
skundrik Aug 11, 2021
6b40a44
start_index is not actually required in _get_generator as it's not used
skundrik Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions atlassian/bamboo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ def _get_generator(
:param path: URI for the resource
:return: generator with the contents of response[elements_key][element_key]
"""
start_index = 0
params["start-index"] = start_index
response = self.get(path, data, flags, params, headers)
if self.advanced_mode:
try:
Expand All @@ -60,7 +58,6 @@ def _get_generator(
for r in results[element_key]:
size += 1
yield r
start_index += results["max-result"]
except TypeError:
logging.error("Broken response: {}".format(response))
yield response
Expand Down