Skip to content

Conversation

@flichtenheld
Copy link
Contributor

  • Added object for DiffStat and moved to its own
    file since it can be generated at different places
    in the API.

Signed-off-by: Frank Lichtenheld frank@lichtenheld.com

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #888 (f914c93) into master (8914cb8) will decrease coverage by 0.03%.
The diff coverage is 60.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
- Coverage   36.44%   36.41%   -0.04%     
==========================================
  Files          32       33       +1     
  Lines        6251     6391     +140     
  Branches      902      984      +82     
==========================================
+ Hits         2278     2327      +49     
- Misses       3865     3956      +91     
  Partials      108      108              
Impacted Files Coverage Δ
...ssian/bitbucket/cloud/repositories/pullRequests.py 89.78% <47.61%> (-3.37%) ⬇️
atlassian/bitbucket/cloud/repositories/diffstat.py 68.57% <68.57%> (ø)
atlassian/xray.py 25.00% <0.00%> (-0.99%) ⬇️
atlassian/jira.py 19.06% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8914cb8...f914c93. Read the comment docs.

@gonchik
Copy link
Member

gonchik commented Dec 27, 2021

@flichtenheld Could you adjust code based on the advice from codacy please ?
https://app.codacy.com/gh/atlassian-api/atlassian-python-api/pullRequest?prid=8434769

* Added object for DiffStat and moved to its own
  file since it can be generated at different places
  in the API.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
@flichtenheld
Copy link
Contributor Author

@flichtenheld Could you adjust code based on the advice from codacy please ? https://app.codacy.com/gh/atlassian-api/atlassian-python-api/pullRequest?prid=8434769

Yeah, I tried. Just caused different issues. Pushed next attempt just now.

@flichtenheld
Copy link
Contributor Author

@flichtenheld Could you adjust code based on the advice from codacy please ? https://app.codacy.com/gh/atlassian-api/atlassian-python-api/pullRequest?prid=8434769

Yeah, I tried. Just caused different issues. Pushed next attempt just now.

So now only one issue remains:

1 blank line required before class docstring (found 0) (D203)

Are you sure about that one? There is literally not a single class in your code that fullfills this. All the existing ones that actually have class comments have them directly after the class statement. Wouldn't it be better to disable D203 and use D211 ("No blank lines allowed before class docstring") instead?

@gonchik gonchik merged commit 31e563d into atlassian-api:master Dec 29, 2021
@gonchik
Copy link
Member

gonchik commented Dec 29, 2021

Let me found how to make an exclusion for codacity

@flichtenheld flichtenheld deleted the pullrequest-diffstat branch February 8, 2022 12:26
gonchik pushed a commit that referenced this pull request Sep 3, 2022
* Added object for DiffStat and moved to its own
  file since it can be generated at different places
  in the API.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants