Skip files that are already transformed #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeLane
requested review from
danieldelcore,
dddlr,
kylorhall-atlassian,
liamqma and
pancaspe87
as code owners
🦋 Changeset detectedLatest commit: 5ac08ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js canceled.
|
marcins
approved these changes
Oct 19, 2025
| // For everything else we bail out. | ||
| return undefined; | ||
| } | ||
| if (code.includes('/* COMPILED_TRANSFORMED_ASSET */')) { |
Collaborator
There was a problem hiding this comment.
I missed this, but yeah, makes perfect sense if that path exists!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
In the parcel transformer, we are going to start getting cases where code is already transformed (when we rollout the SWC plugin). We need to optimise the perf of this path
Why are we making this change?
Currently we'll evaluate pre-transformed code which means parsing and transforming with babel.
How are we making this change?
(Optional.)
PR checklist
Don't delete me!
I have...
website/