Upgrade dependencies and improve testing for Node and TypeScript#33
Merged
Upgrade dependencies and improve testing for Node and TypeScript#33
Conversation
jdyAt
approved these changes
Apr 8, 2026
mma-atl
reviewed
Apr 8, 2026
| expect(formatDateTimeByOptions(option, new Date(2004, 7, 3, 4), 'zh-CN')).toBe('2004年8月3日 04:00'); | ||
| expect(formatDateTimeByOptions(option, new Date(2004, 7, 3, 4), 'ja-JP')).toBe('2004/08/03 4:00'); | ||
| expect(formatDateTimeByOptions(option, new Date(2004, 7, 3, 4), 'ko-KR')).toBe('2004. 8. 3. 오전 4:00'); | ||
| expect(formatDateTimeByOptions(option, new Date(2004, 7, 3, 4), 'ko-KR')).toBe('2004. 8. 3. AM 4:00'); |
Collaborator
There was a problem hiding this comment.
Is this expected? I have no knowledge about the Korean language.
Collaborator
Author
There was a problem hiding this comment.
Yes, caused by node upgrade.
mma-atl
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the codebase. The main changes include modernizing the Node.js version, updating dependencies, refining the release workflow, improving test coverage, and making minor fixes to locale-specific formatting and test data.
Release workflow and CI improvements:
.github/workflows/release.ymlto trigger on tag pushes (matchingv*) instead of manual dispatch with version bump selection. The workflow no longer handles version bumping or git commits/tags, and now uses the pushed tag directly for releases. [1] [2] [3].nvmrcfrom23.10.0to24.14.1to ensure compatibility with the latest features and dependencies.Dependency and build updates:
package.json(includingeslint,typescript, andglobals), increased the package version to0.3.0, and improved theexportsfield for better type and module resolution. Thechecksscript now includes a build step. [1] [2]ts-loaderoptions, ensuring proper TypeScript compilation and output.Testing improvements:
src/index.dist.test.tsto verify that all expected APIs are exported from the CJS bundle and that all distribution bundles exist and are non-empty.Locale and formatting fixes:
Minor code fixes:
formatDurationByOptionsby removing the unnecessary initialization ofdurationString.Rovo Dev code review: Rovo Dev has reviewed this pull request
Any suggestions or improvements have been posted as pull request comments.