Closed
Conversation
There's a couple of problems here: 1. We subscribe a telemetry endpoint before the service is ready. If we receive a flush to that endpoint, then we try to perform a flush and get an NPE. 2. The access to the flusher is unprotected across multiple goroutines. We just use an RWMutex for this, because it's rarely accessed and doesn't need anything fancy. 3. There's a race condition in the test because the nop write is (was) async.
|
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
Collaborator
Author
|
Dangit wrong account |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a couple of problems here:
We subscribe a telemetry endpoint before the service is ready. If we receive a flush to that endpoint, then we try to perform a flush and get an NPE.
The access to the flusher is unprotected across multiple goroutines. We just use an RWMutex for this, because it's rarely accessed and doesn't need anything fancy.
There's a race condition in the test because the nop write is (was) async.