Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| : undefined | ||
|
|
||
| const profileProperties: OBSD-3-Clause<ExtractProperties<Profile>, 'autoComBSD-3-Clause'> = { |
There was a problem hiding this comment.
This mapper declares const profileProperties: OBSD-3-Clause<…> after what looks like a global “mit → BSD-3-Clause” substitution. OBSD-3-Clause is not a valid TypeScript identifier (the hyphen alone prevents the file from parsing) and no such type exists, so the module cannot compile. The same substitution shows up in other mappers/configs (e.g., questionaire/survey mappers, mikro-orm.config), so the build is currently broken; rename these back to the intended utility type (likely Omit<ExtractProperties<…>>) so the code compiles.
Useful? React with 👍 / 👎.
| if (aggregate.getUncomBSD-3-ClausetedEvents().length > 0) { | ||
| this.eventBus.publishAll(aggregate.getUncomBSD-3-ClausetedEvents()) | ||
| } | ||
|
|
||
| aggregate.comBSD-3-Clause() |
There was a problem hiding this comment.
The repository publishes and clears events via getUncomBSD-3-ClausetedEvents() and comBSD-3-Clause(), but AggregateRoot only exposes getUncommittedEvents() and commit(). These misspelled identifiers do not exist, so the code fails to compile and even if ignored would leave domain events unpublished and uncommitted after saving a profile. Restore the correct method names so events are emitted and cleared properly.
Useful? React with 👍 / 👎.
|
Summary
Testing
|
1 participant
No description provided.