Uncaught TypeError: Cannot read property 'length' of undefined

[bgc]

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 1.0.3-3d861c7
System: Ubuntu 14.04.2
Thrown From: minimap-git-diff package, v4.1.5

Stack Trace

Uncaught TypeError: Cannot read property 'length' of undefined

At /home/gcosta/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:68

TypeError: Cannot read property 'length' of undefined
  at MinimapGitDiff.destroyBindings (/home/gcosta/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:68:5)
  at MinimapGitDiff.destroyBindings (/home/gcosta/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:1:1)
  at /home/gcosta/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:50:10
  at Emitter.module.exports.Emitter.emit (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at Project.module.exports.Project.addPath (/usr/local/share/atom/resources/app.asar/src/project.js:274:29)
  at EventEmitter.<anonymous> (/usr/local/share/atom/resources/app.asar/src/window-event-handler.js:37:32)
  at emitTwo (events.js:87:13)
  at EventEmitter.emit (events.js:169:7)

Commands

Config

{
  "core": {
    "ignoredNames": [
      ".git",
      ".DS_Store",
      "nbproject",
      "idea"
    ],
    "disabledPackages": [
      "metrics",
      "tree-view-open-files",
      "gamboge",
      "scope-inspector",
      "jsdoc",
      "xml-formatter",
      "merge-conflicts",
      "linter-perl",
      "perltidy",
      "atom-jshint",
      "timecop",
      "welcome",
      "spell-check",
      "release-notes",
      "language-latex",
      "powerline",
      "vim-mode",
      "language-javascript-semantic",
      "org",
      "mechanical-keyboard",
      "language-csharp",
      "language-ruby",
      "language-ruby-on-rails",
      "language-toml",
      "language-yaml",
      "language-property-list",
      "language-objective-c",
      "feedback",
      "exception-reporting",
      "language-mustache",
      "emacs-flow",
      "atom-ternjs",
      "slack-chat",
      "todo-list"
    ],
    "themes": [
      "isotope-ui",
      "viriato"
    ],
    "projectHome": "/home/gcosta/workspace",
    "followSymlinks": true
  }
}

Installed Packages

# User
file-icons, v1.5.8
git-log, v0.4.1
highlight-line, v0.11.0
htmlhint, v1.1.3
isotope-ui, v2.5.0
jsonlint, v1.1.2
line-ending-converter, v1.2.0
linter, v1.2.3
linter-eslint, v2.4.1
method-separator, v0.1.3
minimap, v4.11.2
minimap-bookmarks, v0.1.0
minimap-color-highlight, v4.1.4
minimap-find-and-replace, v4.2.0
minimap-git-diff, v4.1.5
pretty-json, v0.4.1
tasks, v2.2.0
viriato, v0.11.0

# Dev
No dev packages

[abe33]

Sorry, my mistake, I should have tested more throroughly the fix leak PR released in the latest version, I'll push a patch soon.

[sdaitzman]

👍

[Arcanemagus]

I'm still seeing this in 4.1.6.

I'm still seeing this in 4.1.6

[abe33]

This cannot be the same error. If the stack trace is different it's a different error, but without a stack trace I can't do anything.

[SebastianSzturo]

Stack Trace:

TypeError: Cannot read property 'length' of undefined
    at MinimapGitDiff.destroyBindings (/Users/sebastian/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:106:33)
    at MinimapGitDiff.destroyBindings (/Users/sebastian/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:3:61)
    at /Users/sebastian/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:71:26
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
    at Project.module.exports.Project.addPath (/Applications/Atom.app/Contents/Resources/app.asar/src/project.js:274:29)
    at EventEmitter.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:37:32)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:169:7)

[abe33]

Thanks for the feedback, but it doesn't really make sense, the only place where a length is accessed in this function is to loop over the existing minimaps, but there's an explicit test the line before so we return if there's no minimap collections:

https://github.com/atom-minimap/minimap-git-diff/blob/master/lib/minimap-git-diff.coffee#L67-L68

Does a restart helps? Maybe you got the error while updating the package and the old code was still executed.

[SebastianSzturo]

It seams like a restart helped and everything is working fine again.
Thank you very much! :)

[sdaitzman]

I'm no longer seeing the issue, thank you ❤️

[MageLuingil]

I'm getting this error as well. Restarting the editor does solve the issue, but the error seems to always happen the first time a new project is opened in Atom.

It's not a huge problem, but it is reproducible.

Steps to reproduce:

1. Open a project that has not been opened in Atom before, using atom . from terminal.

Atom Version: 1.0.0
System: Linux Mint
Thrown From: minimap-git-diff package, v4.1.6

Stack Trace

Uncaught TypeError: Cannot read property 'length' of undefined

At /home/dmatthies/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:68

TypeError: Cannot read property 'length' of undefined
    at MinimapGitDiff.destroyBindings (/home/dmatthies/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:106:33)
    at MinimapGitDiff.destroyBindings (/home/dmatthies/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:3:61)
    at /home/dmatthies/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:71:26
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
    at Project.module.exports.Project.addPath (/usr/share/atom/resources/app.asar/src/project.js:274:29)
    at EventEmitter.<anonymous> (/usr/share/atom/resources/app.asar/src/window-event-handler.js:37:32)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:169:7)

[michaelaye]

Also happens for me with using atom filename in the terminal.

[Enter steps to reproduce below:]

1. ...
2. ...

**Atom Version**: 1.0.0
**System**: Mac OS X 10.10.3
**Thrown From**: [minimap-git-diff](https://github.com/atom-minimap/minimap-git-diff) package, v4.1.6


### Stack Trace

Uncaught TypeError: Cannot read property 'length' of undefined

At /Users/klay6683/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:68

TypeError: Cannot read property 'length' of undefined
at MinimapGitDiff.destroyBindings (/Users/klay6683/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:68:5)
at MinimapGitDiff.destroyBindings (/Users/klay6683/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:1:1)
at /Users/klay6683/.atom/packages/minimap-git-diff/lib/minimap-git-diff.coffee:50:10
at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
at Project.module.exports.Project.addPath (/Applications/Atom.app/Contents/Resources/app.asar/src/project.js:274:29)
at EventEmitter. (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:39:32)
at emitTwo (events.js:87:13)
at EventEmitter.emit (events.js:169:7)

### Commands

 -0:02.0 window:update-available (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)

### Config

```json
{
  "core": {}
}

Installed Packages

# User
autocomplete-python, v0.5.1
color-picker, v2.0.9
git-diff-details, v0.18.0
git-log, v0.4.1
language-gitignore, v0.2.0
linter-flake8, v1.5.0
minimap, v4.11.2
minimap-git-diff, v4.1.6
my-github-profile, v0.2.1
tab-numbers, v0.2.0
travis-ci-status, v0.16.0
tree-view-git-modified, v0.5.10
tree-view-git-status, v0.1.1

# Dev
No dev packages

Oh, and that file does not exist, so I wanted atom to create a new file with that name? Maybe that is broken?

Edit: Yes, confirmed. If the file exists, the error does not appear. atom . in a folder that was not used before also does NOT throw this error for me.

[abe33]

@michaelaye Thank you! I was able to reproduce that with your steps. Another example of the difficulty to use unless... The or was supposed to be an and instead. I'll push a patch soon.