Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@kevinsawicki
Copy link
Contributor

Support converting https://raw.github.com/itsthatguy/theme-itg-flat/master/itg.dark.tmTheme style themes where the main colors aren't the first element in the array.

  • Look for main block without a name or scope to determining the "core settings" of the theme that are translated to variables
  • Throw an error if the 6 required variables aren't present because if any are missing the generated theme will not be valid LESS since it will have left-over `{{..}`` markers in it.

Tested that is was still compatible with these style themes as well: https://raw.github.com/chriskempson/tomorrow-theme/master/textmate/Tomorrow-Night-Eighties.tmTheme

/cc @benogle

@nathansobo
Copy link
Contributor

Looks good.

@benogle
Copy link
Contributor

benogle commented Mar 6, 2014

:shipit:

kevinsawicki added a commit that referenced this pull request Mar 6, 2014
Support converting more TextMate theme styles
@kevinsawicki kevinsawicki merged commit cf1578e into master Mar 6, 2014
@kevinsawicki kevinsawicki deleted the ks-support-alternate-theme-format branch March 6, 2014 22:26
DeeDeeG pushed a commit to DeeDeeG/apm that referenced this pull request Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants